SRFE-8790 cleanup child nodes recursively - #12
Merged
Conversation
jakewski
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on this some more. The previous change helped was using
removeNodeFromMapwhich recursively went through the child nodes to remove them from the map which holds strong references thus preventing GC. But for iframes, we also need to check contentDocumentIn this change we recurse through the child nodes as well as part of cleanup.. Attaching a log file as well which shows a decrease in the mirror size.
logs4.txt
Also updated upstream pr https://github.com/rrweb-io/rrweb/pull/1791/changes