scp: Fix ascii_isdigit build failure - #475
Merged
Merged
Conversation
Move ctype replacements to dbctype.c, include it for scp. Fixes: 7af125a ("Move ctype replacement functions to dbutil.c")
The warning is spurious since the buffer size is checked prior to snprintf. The warning seems to only occur with -O2, not -Os. No functional change. src/scp.c:1031:56: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 2 and 4095 [-Werror=format-truncation=]
Some compilers treat strchr() return value as const char* No functional change.
nondefault build would always add "DEBUG_TRACE 1", conflicting with the explicit "DEBUG_TRACE 5"
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jul 23, 2026
https://matt.ucc.asn.au/dropbear/CHANGES Removed patch, the build error was fixed upstream by mkj/dropbear#475 Signed-off-by: Bernd Kuhls <bernd@kuhls.net> Signed-off-by: Julien Olivain <ju.o@free.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ctype replacements to dbctype.c, include it for scp.
Fixes: 7af125a ("Move ctype replacement functions to dbutil.c")
Fixes #473
The first commit fixes the problem, the others are adding CI for scp and other CI problems noticed in the process.