scp: fix build with gcc >= 14.x - #474
Closed
bkuhls wants to merge 1 commit into
Closed
Conversation
Fixes build errors seen with gcc 14.x: src/scp.c: In function ‘sink’: src/scp.c:1214:32: error: implicit declaration of function ‘ascii_isdigit’ [-Wimplicit-function-declaration] src/scp.c: In function ‘okname’: src/scp.c:1501:22: error: implicit declaration of function ‘ascii_isalpha’ [-Wimplicit-function-declaration] Patch provided by SVoxel: mkj#473 Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
|
You're not getting an error at link time? ( |
Author
Correct, for whatever reason. I found the build error while preparing the version bump for the buildroot project and most of their Gitlab pipelines failed without this fix, only some toolchains using older gcc versions could build the new version: With this patch all pipelines passed: |
|
It's because you're building with |
Owner
|
#475 has a fix merged now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build errors seen with gcc 14.x:
Patch provided by SVoxel: #473