fix(storage#782): exclude write-side teardown from §4.7.1 failover-callout gap#787
Merged
FileSystemGuy merged 2 commits intoJul 13, 2026
Merged
Conversation
…llout gap The split-mode failover-callout gap check charged the write phase's post-benchmark work — final multi-node cluster collection, metadata serialization, interpreter shutdown — against the 30-second budget by measuring from write.summary.end_time (end of the timed section). On large topologies that teardown can take tens of seconds, causing false failures on legitimate submissions whose real inter-invocation handoff is within budget. Adds a symmetric write-side bookend to mirror the read-side fix from storage#714. _invocation.INVOCATION_END is captured at the top of write_metadata() — the latest moment where the value can still land in the persisted file — and emitted as metadata.invocation_end_time. The submission checker prefers it over summary.end_time, so post-benchmark teardown is now excluded from the gap on both sides of the handoff. Falls back to summary.end_time for older results dirs (pre-fix behavior). Emits an INFO line per pair with the chosen origin so the measurement is transparent regardless of pass/warn/fail.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #782. The split-mode failover-callout gap check charged the write phase's post-benchmark work — final multi-node cluster collection, metadata serialization, interpreter shutdown — against the 30-second budget by measuring from
write.summary.end_time(end of the timed section). On large topologies that teardown can take tens of seconds, causing false failures on legitimate submissions whose real inter-invocation handoff is within budget.Adds a symmetric write-side bookend to mirror the read-side fix from #714:
_invocation.py— newINVOCATION_END+mark_invocation_end(), symmetric with the existingINVOCATION_START.benchmarks/base.py— callsmark_invocation_end()at the top ofwrite_metadata(), the latest moment where the value can still land in the persisted file. Emits it asmetadata['invocation_end_time'].cache_flush_validation— preferswrite.metadata.invocation_end_timeas the write-side origin, falling back towrite.summary.end_timefor older results dirs (pre-fix behavior). Emits an INFO line per pair with the chosen origin so the measurement is transparent regardless of pass / warn / fail.Now the two bookends are genuinely symmetric: whatever falls outside
INVOCATION_START/INVOCATION_ENDis excluded from the gap on both sides — framework startup on the read side, and post-benchmark cluster collection, rank-0 teardown, JSON serialization, and interpreter shutdown on the write side.Worked example (from #782)
write.summary.end_time(timed section ends)2026-07-13T06:36:25write.metadata.invocation_end_time(nodes released, rank 0 exiting)2026-07-13T06:37:03read.metadata.invocation_start_time2026-07-13T06:37:29read_start − summary_end)read_start − invocation_end)Test plan
mlpstorage_py/tests— 850 passed (includes 3 new §4.7.1 tests)tests/— 2907 passed, 1 skipped, 13 deselectedvdb_benchmark/tests— 174 passedkv_cache_benchmark/tests— 238 passedNew tests
test_split_mode_write_teardown_excluded_from_gap— issue Validation §4.7.1checkpointCacheFlushValidationunfairly charges the write phase's final multi-node collection to the failover-callout budget #782 scenario: 45s teardown + 25s real gap ⇒ PASS.test_split_mode_missing_invocation_end_time_falls_back_to_summary_end— pre-Validation §4.7.1checkpointCacheFlushValidationunfairly charges the write phase's final multi-node collection to the failover-callout budget #782 results dirs still measure againstsummary.end_time(unchanged behavior).test_split_mode_info_line_emitted_on_pass— INFO transparency line is emitted on every pair.