fix(storage#795): align datasize output and fail-fast on flat storage_options typos#797
Merged
Merged
Conversation
…_options typos Fixes three bugs surfaced by the storage#795 reporter: 1. Datasize INFO log used the workload YAML default (retinanet_b200: 1,170,301) for the "skip_listing enabled: N train files" message, contradicting the "Number of training files: 257,173" result line printed a moment later. Move the _apply_skip_listing_params call from __init__ to datasize() where the DRAM-derived recommendation is authoritative. 2. Emitted datagen-command hint bundled dataset.num_files_train=257173 with dataset.listing_validation_interval=1000 — the interval bucket is right for the YAML default, wrong for the recommendation. Both values now agree because the same deferred call sets the interval. 3. Flat --params storage.storage_library=s3dlio (a typo of storage.storage_options.storage_library) had no effect on the run (the tool auto-injects the nested form) but tripped the CLOSED disallowed-override check with a message that didn't point at the correct spelling. Add a KNOWN_PARAM_TYPOS map and fail fast at CLI parse time; append the "Did you mean X?" hint to the runtime and submission-checker (3.6.2, 3.6.3) disallowed-override messages so old submissions get the suggestion at validate time too. Behavior for non-datasize commands is unchanged: _apply_skip_listing_params still reads combined_params on the run/datagen/configview/reportgen path. No new CLI flag — num_files_override is an internal parameter used only by datasize().
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #795.
Summary
Reporter ran
mlpstorage open training retinanet datasizefor a b200/15GiB host and saw the recommendation "Number of training files: 257,173" — but the log line one second earlier said "skip_listing enabled: 1,170,301 train files", and the emitted datagen-command hint bundlednum_files_train=257173withlisting_validation_interval=1000(right bucket for 1.17M, wrong for 257K). Their laterrunalso failed withDisallowed parameter override: storage.storage_library = s3dliowhen they tried to pass the storage backend explicitly.Three related bugs, one PR:
Datasize log/hint discrepancy:
_apply_skip_listing_paramsran in__init__beforedatasize()computed its recommendation, so it readnum_files_trainfrom the workload YAML default (retinanet_b200.yaml: 1170301). Moved the call to fire indatasize()after the DRAM-derived recommendation lands inparams_dict, threaded through asnum_files_override. Now the INFO log, theNumber of training files:result line, and the emitted datagen-hint's interval all agree.Emitted datagen-hint inconsistency: same root cause — the hint's
listing_validation_intervalcame from the pre-computed injection. Fixed by (1).Flat
storage.storage_librarytypo UX: the flat form isn't a real DLIO config path; the tool auto-injectsstorage.storage_options.storage_libraryfromSTORAGE_LIBRARYenv in--objectmode, so the user's--paramshad zero effect on the run. But the CLOSED disallowed-override check rejected it with a message that didn't hint at the correct spelling. Addedmlpstorage_py/rules/param_hints.pywith aKNOWN_PARAM_TYPOSmap (three known-typo entries:storage.storage_library,storage.uri_scheme,storage.prefetch_window), a fail-fast gate incli_parser.update_argsso the user doesn't wait through MPI cluster collection just to be told the param was wrong, and a "Did you mean X?" hint appended to the runtime and submission-checker (3.6.2 CLOSED, 3.6.3 OPEN) disallowed-override messages somlpstorage validateon stored submissions gives the same suggestion.Backwards compatibility
num_files_overrideis an internal Python parameter used only bydatasize().listing_validation_intervalcontrols startup HEAD-check density, not measured throughput; both values pre/post fix are TOOL_INJECTED_PARAMS and don't gate any rule.Test plan
uv run pytest tests— 2925 passed, 1 skipped, 13 deselected (+9 new)uv run pytest mlpstorage_py/tests— 866 passeduv run pytest vdb_benchmark/tests— 174 passeduv run pytest kv_cache_benchmark/tests— 238 passedNew tests:
tests/unit/test_skip_listing_datasize_interval.py(3 tests) — override wins overcombined_paramsfor the 257,173 recommendation, no-override still falls back to combined_params for non-datasize commands, user-supplied--params dataset.listing_validation_interval=Nstill short-circuits.tests/unit/test_param_typo_hints.py(9 tests) — typo-map integrity, CLI-parse fail-fast for the reporter's exact command shape, multiple typos surfaced in one error, canonical nested form still accepted, runtime check appends hint, unknown-typo message unchanged.