Skip to content

Clarify docdict["filter_length_notch"] - #14113

Merged
drammock merged 3 commits into
mne-tools:mainfrom
cbrnr:notch-spectrum-fit
Jul 30, 2026
Merged

Clarify docdict["filter_length_notch"]#14113
drammock merged 3 commits into
mne-tools:mainfrom
cbrnr:notch-spectrum-fit

Conversation

@cbrnr

@cbrnr cbrnr commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Removed old MNE version info, clarify that "auto" corresponds to "10s" if method=="spectrum_fit", and format as description block (consistent with other entries).

@cbrnr cbrnr added the DOC label Jul 30, 2026
@cbrnr

cbrnr commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@drammock
drammock enabled auto-merge (squash) July 30, 2026 14:28
@cbrnr

cbrnr commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Seems like auto-merge isn't working when some checks are disabled...

@drammock
drammock disabled auto-merge July 30, 2026 18:22
@drammock
drammock merged commit 8854ea4 into mne-tools:main Jul 30, 2026
13 checks passed
@drammock

Copy link
Copy Markdown
Member

ah yep. didn't notice the [skip actions] tag

@cbrnr
cbrnr deleted the notch-spectrum-fit branch July 30, 2026 19:28
larsoner added a commit to larsoner/mne-python that referenced this pull request Aug 4, 2026
* upstream/main: (35 commits)
  Fix bug with coreg scaling (mne-tools#14132)
  MAINT: Update code credit (mne-tools#14131)
  Fix bugs with dark mode panels (mne-tools#14109)
  Improve code credit workflow (mne-tools#14120)
  Align _AbstractRenderer.tube with the PyVista implementation (mne-tools#14125)
  Assign instead of compare when marking explicit zeros in spatio_temporal_dist_adjacency (mne-tools#14124)
  MAINT: Update pre-commit hook versions (mne-tools#14122)
  MAINT: Update dependency specifiers (mne-tools#14121)
  fix: correct typo in comment (mne-tools#14117)
  [dependabot]: Bump the actions group with 2 updates (mne-tools#14123)
  Fix` read_raw_eyelink()` failure when recording blocks are empty or starting with empty values (mne-tools#13571)
  ENH: Add `event_key` parameter to `read_raw_egi` for MFF event metadata (mne-tools#14086)
  fix for scipy sparse deprecations (mne-tools#14118)
  Fix notch spectrum fit (mne-tools#14116)
  Speed up notch filter spectrum fit (mne-tools#14114)
  fix MNE-RT links and update roadmap (mne-tools#14096)
  Clarify `docdict["filter_length_notch"]` (mne-tools#14113)
  Refactor test_plot_alignment_basic() (mne-tools#13472)
  BUG: Cleanup cHPI filtering using smooth interpolation (mne-tools#14112)
  Use redirector app (mne-tools#14111)
  ...

# Conflicts:
#	mne/tests/test_filter.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants