Skip to content

fix: accept catalog defaults in Python validation - #194

Merged
guillaumegay13 merged 1 commit into
mnfst:mainfrom
guillaumegay13:guillaumegay13/fix-python-defaults-validation
Aug 4, 2026
Merged

fix: accept catalog defaults in Python validation#194
guillaumegay13 merged 1 commit into
mnfst:mainfrom
guillaumegay13:guillaumegay13/fix-python-defaults-validation

Conversation

@guillaumegay13

Copy link
Copy Markdown
Collaborator

✨ What changed

  • Normalize Mapping inputs before Pydantic validation.
  • Add regression coverage for passing get_defaults() directly.

💭 Why

get_defaults() returns an immutable mapping. Passing it to validate_params() previously failed at runtime.

👤 For users

Catalog defaults can now be validated without a manual dict conversion.

📝 Notes

Validated with 22 Python tests, Ruff, formatting, mypy, wheel/Twine checks, and installed-wheel smoke.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

@guillaumegay13 is attempting to deploy a commit to the Manifest Team on Vercel.

A member of the Team first needs to authorize it.

@guillaumegay13
guillaumegay13 merged commit a49a378 into mnfst:main Aug 4, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant