Skip to content

fix: accept catalog defaults in Python validation #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumegay13 merged 1 commit into from
Aug 4, 2026
+8 −0
Merged

fix: accept catalog defaults in Python validation #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/modelparams-python/src/modelparams/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

from collections.abc import Mapping
from functools import cache
from typing import Any, cast

Expand All @@ -16,4 +17,6 @@ def params_adapter(model_id: ModelId) -> TypeAdapter[Any]:


def validate_params(model_id: ModelId, params: object) -> dict[str, JsonPrimitive]:
if isinstance(params, Mapping):
params = dict(params)
return cast(dict[str, JsonPrimitive], params_adapter(model_id).validate_python(params))
5 changes: 5 additions & 0 deletions packages/modelparams-python/tests/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ def test_accepts_valid_and_empty_params() -> None:
assert validate_params(GPT, {}) == {}


def test_accepts_catalog_defaults_mapping() -> None:
defaults = get_defaults(GPT)
assert validate_params(GPT, defaults) == dict(defaults)


def test_rejects_unknown_keys_and_collects_errors() -> None:
with pytest.raises(ValidationError) as caught:
validate_params(GPT, {"temperature": 5, "nope": 1})
Expand Down
Loading