HTTP source - #168
Merged
Merged
Conversation
AkihiroSuda
reviewed
Nov 17, 2017
| func (hs *httpSource) Resolve(ctx context.Context, id source.Identifier) (source.SourceInstance, error) { | ||
| httpIdentifier, ok := id.(*source.HttpIdentifier) | ||
| if !ok { | ||
| return nil, errors.Errorf("invalid git identifier %v", id) |
Closed
tonistiigi
force-pushed
the
http-source
branch
from
December 2, 2017 02:23
5677b5d to
0b8c851
Compare
Member
Author
|
@AkihiroSuda Added the tests and this should be ready for review now. I think we should probably add support for more headers like |
tonistiigi
force-pushed
the
http-source
branch
from
December 2, 2017 03:18
0b8c851 to
3f1c1e7
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
http-source
branch
from
December 4, 2017 20:01
3f1c1e7 to
e0af9d1
Compare
Member
Author
|
Added more commits for overriding properties of the downloaded file, setting modified time from the header, etc. |
AkihiroSuda
approved these changes
Dec 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #37
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com