Skip to content

dockerfile: Add ADD from archive support - #189

Merged
AkihiroSuda merged 1 commit into
moby:masterfrom
tonistiigi:extraction
Dec 5, 2017
Merged

dockerfile: Add ADD from archive support#189
AkihiroSuda merged 1 commit into
moby:masterfrom
tonistiigi:extraction

Conversation

@tonistiigi

Copy link
Copy Markdown
Member

based on #168

New copy image is built from tonistiigi/copy#1 , although after finishing it I don't think this is the correct way how this image should be built. I was trying to avoid reimplementing copy/extract in go and use standard tools but there is no easy way to implement COPY --chown in this method. So probably the implementation will change but chang in this repo should be ok.

@AkihiroSuda

Copy link
Copy Markdown
Member

LGTM but needs rebase 😅

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
AkihiroSuda merged commit 9397eb2 into moby:master Dec 5, 2017
crazy-max pushed a commit to crazy-max/buildkit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants