vendor: revert github.com/moby/go-archive v0.2.1 - #7005
Merged
crazy-max merged 4 commits intoJul 31, 2026
Conversation
This reverts commit 53b2d03. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
github-actions
Bot
added
area/dockerfile
area/testing
area/dependencies
crazy-max
marked this pull request as ready for review
July 31, 2026 11:23
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
vvoland
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
CopyToContainerregression in 29.7.0: "path escapes from parent" when copying into paths that traverse/var/run → /runsymlink moby#53258This reverts the go-archive bump from v0.2.0 to v0.2.1 introiduced in #7005 because v0.2.1 regresses Dockerfile
ADDextraction for tar archives that contain a directory entry whose parent directory is only implied by the tar path. BuildKit is affected through the local archive extraction path insolver/llbsolver/file/unpack.go, which useschrootarchive.Untar.Jumping directly to go-archive v0.3.0 is not the right patch-release fix. The v0.3.0 release still has the implied-parent directory behavior until moby/go-archive#92 is released, so it does not address the
ADDregression by itself. It also brings the neweros.Rootextraction changes, which are connected to the separate absolute-symlink compatibility regression reported in moby/moby#53258 and to the BuildKit performance concerns discussed in #6964.For this BuildKit patch release, the lowest-risk fix is to restore the last known-good go-archive release and wait for an upstream go-archive patch release that includes moby/go-archive#92. A later bump can then evaluate the complete fixed go-archive release, including the
os.Rootbehavior and the performance impact, as its own change.This was reproduced with a local Dockerfile build using
ADD layer.tar.gz /, which fails on current BuildKit withmkdir /etc/dnf: no such file or directory. This PR adds integration coverage for that implied-parent archive shape and also adds coverage for extracting archive contents through an absolute symlink such as/var/run -> /run, so future go-archive bumps have tests for both compatibility cases.