[24.0 backport] vendor: github.com/docker/distribution v2.8.3

[thaJeztah]

backports of;

• fix faulty tests for distribution-client #46555

• vendor: github.com/docker/distribution v2.8.3 #46542

• relates to Pushing blobs doesn't send content-type #46006

• fixes Pushing blobs doesn't send content-type #46006

Diff is different, because the 24.0 branch still uses the deprecated reference package, and doesn't contain;

• migrate to new github.com/distribution/reference module #46376

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Interesting failures; they look like actual failures, but curious how the failures relate to these changes 🤔

failed to start daemon: insecure registry insecurehost.com:5000 is not valid: invalid host "insecurehost.com"

=== Failed
=== FAIL: daemon TestDaemonReloadAllowNondistributableArtifacts (0.00s)
    reload_test.go:71: allow-nondistributable-artifacts registry docker1.com is not valid: invalid host "docker1.com"

=== FAIL: daemon TestDaemonReloadInsecureRegistries (0.00s)
    reload_test.go:228: insecure registry docker1.example.com is not valid: invalid host "docker1.example.com"

=== FAIL: registry TestLoadAllowNondistributableArtifacts (0.00s)
    config_test.go:125: expect error 'allow-nondistributable-artifacts registry myregistry.example.com:500000 is not valid: invalid port "500000"', got 'allow-nondistributable-artifacts registry myregistry.example.com:500000 is not valid: invalid host "myregistry.example.com"'

=== FAIL: registry TestLoadInsecureRegistries (0.00s)
time="2023-10-18T16:01:47Z" level=warning msg="insecure registry http://myregistry.example.com should not contain 'http://' and 'http://' has been removed from the insecure registry config"
    config_test.go:244: expect no error, got 'insecure registry myregistry.example.com is not valid: invalid host "myregistry.example.com"'

=== FAIL: registry TestNewIndexInfo (0.00s)
    registry_test.go:421: insecure registry example.com is not valid: invalid host "example.com"

=== FAIL: registry TestAllowNondistributableArtifacts (0.00s)
    registry_test.go:660: allow-nondistributable-artifacts registry example.com is not valid: invalid host "example.com"
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x949aa5]

goroutine 199 [running]:
testing.tRunner.func1.2({0x9c0260, 0xef40a0})
	/usr/local/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x39f
panic({0x9c0260, 0xef40a0})
	/usr/local/go/src/runtime/panic.go:884 +0x213
github.com/docker/docker/registry.(*serviceConfig).allowNondistributableArtifacts(...)
	/go/src/github.com/docker/docker/registry/config.go:257
github.com/docker/docker/registry.TestAllowNondistributableArtifacts(0xc00036d520)
	/go/src/github.com/docker/docker/registry/registry_test.go:662 +0x705
testing.tRunner(0xc00036d520, 0xaa9370)
	/usr/local/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x3ea

DONE 2994 tests, 26 skipped, 6 failures in 312.017s
make: *** [Makefile:218: test-unit] Error 1
Error: Process completed with exit code 2.

[thaJeztah]

🙈 😬 found it 😬 looks like I've been a victim of auto-complete in distribution;

moby/vendor/github.com/docker/distribution/reference/regexp_deprecated.go

Line 23 in 5338c06

var DomainRegexp = reference.DigestRegexp

[thaJeztah]

closing; there's no plans to do more 24.0.x releases