integration-cli/container: Rewrite on-failure restart tests#52882
Merged
Conversation
Replace flaky legacy CLI restart-policy tests with container API integration coverage. The CLI tests poll inspect output after short-lived detached containers exit, which can observe transient daemon monitor state while cleanup or restart-policy handling is still settling. On Windows this can race a manual restart against an `on-failure:3` container that has not exhausted its automatic retries. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace flaky legacy CLI restart-policy tests with container API integration coverage.
The CLI tests poll inspect output after short-lived detached containers exit, which can observe transient daemon monitor state while cleanup or restart-policy handling is still settling.
On Windows this can race a manual restart against an
on-failure:3container that has not exhausted its automatic retries.Remove flaky tests:
Verify TestContainerRestartPolicyOnFailure is not flaky
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)