Support links via anchor ("a") elements #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add links using Prawn's `link_annotation`. This works with any element that defines a bounding box, and also text. We transform the bounding box into PDF page space so that the link area will tightly fit a rotated rectangle, for example. One thing that isn't supported is adding links inside a text element, for example: ```svg <text>Text with a <a href="...">link</a> inside.</text> ``` I believe this is valid SVG, but the current parser in prawn-svg doesn't handle this nesting, so it is beyond the scope of this change.
Owner
|
@tonymarklove, thank you so much for this very useful and beautifully written PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links using Prawn's
link_annotation. This works with any element that defines a bounding box, and also text. We transform the bounding box into PDF page space and then fit the link area as tightly as we can around the resulting box. This means the link area will tightly fit a rotated rectangle, for example.One thing that isn't supported is adding links inside a text element. If you have the following markup:
I believe this is a valid SVG, but the current parser in prawn-svg doesn't handle this nesting, so it is beyond the scope of this PR.