Skip to content

Develop#13

Merged
egkhamis merged 6 commits into
monanadmin:developfrom
saulorfreitas:develop
Mar 31, 2025
Merged

Develop#13
egkhamis merged 6 commits into
monanadmin:developfrom
saulorfreitas:develop

Conversation

@saulorfreitas

Copy link
Copy Markdown
Contributor

This should be the base of the first pre-operational version of MONAN. This version contains GF retuning and a few more changes for limited area runs. It defaults the suite 'convection_permitting_monan' for the pre-operational implementation by the DIPTC. It also contains changes in the 'diagnostic' directory.
To do by the GCC-DMINT: The messages "srf: initial soil moisture reduced by 30%" written in the log file by each mpi task should be written only by the "mpi master,"

@egkhamis egkhamis self-assigned this Mar 31, 2025
@egkhamis
egkhamis self-requested a review March 31, 2025 18:20

@egkhamis egkhamis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found some issues that was commented and need to be fixed:

  • the missing variables lh_spr and hfx_spr must be included in the diag_physics pool
  • the variable rqvcuten is missing in the Registry.xml
  • The variable rqvcuten is missing in the mpas_init_atm_cases.F code

call mpas_pool_get_array(diag_physics,'znt' ,znt )
call mpas_pool_get_array(diag_physics,'zol' ,zol )

call mpas_pool_get_array(diag_physics,'lh_spr' ,lh_spr )

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the missing variables lh_spr and hfx_spr must be included in the diag_physics pool (call mpas_pool_get_array(...))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable rqvcuten is missing in the Registry:

        <var_struct name="tend_physics" time_levs="1">
                <var name="rqvcuten" type="real" dimensions="nVertLevels nCells Time" units="kg kg^{-1} s^{-1}"
                     description="tendency of water vapor mixing ratio due to cumulus convection"
                     packages="met_stage_out"/>
        </var_struct>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable does not need to be in init_atmosphere.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed to create code in compilation time to activate the tend_physics pool, the same will happen with the model. Also, there are problems with init_atmosphere compiled in debug mode, it will not run without this variable (or any other in tend_physics).

@egkhamis egkhamis Mar 31, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable rqvcuten is missing in the code:

real (kind=RKIND), dimension(:,:), pointer :: rqvcuten

call mpas_pool_get_array(tend_physics, 'rqvcuten', rqvcuten)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable does not need to be in init_atmosphere.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed to create code in compilation time to activate the tend_physics pool, the same will happen with the model. Also, there are problems with init_atmosphere compiled in debug mode, it will not run without this variable (or any other in tend_physics).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Then, we need to report this potential 'bug' to NCAR people.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the missing variables lh_spr and hfx_spr must be included in the diag_physics pool:

call mpas_pool_get_array(diag_physics,'lh_spr' ,lh_spr )
call mpas_pool_get_array(diag_physics,'hfx_spr',hfx_spr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants