Skip to content

Develop#8

Merged
deniseiras merged 33 commits into
monanadmin:developfrom
saulorfreitas:develop
Oct 4, 2024
Merged

Develop#8
deniseiras merged 33 commits into
monanadmin:developfrom
saulorfreitas:develop

Conversation

@saulorfreitas

Copy link
Copy Markdown
Contributor

Main changes in this version:

  1. adding namelist options in GF MONAN to activate the cold pool scheme,…
  2. adding subsidence spreading
  3. including mpi exchange for 1-d array
  4. including subsidence tendency for U and V
  5. changing packages dependence of buoyx and cnvcf scalars
  6. including directory with MONAN specific namelists
  7. overwritten the GF namelist option with MPAS namelist_atmosphere spec…
  8. fix access to array not allocated when using CAM SW radiation scheme
  9. using the tendency potential temp to limit the max and min heating rates
  10. adding routine for applying turbulent mixing in the dry PBL for extra…
  11. minor changes

saulorfreitas and others added 30 commits June 9, 2024 18:42
…, implementing the enhancing of ocean surface fluxes due the sub-grid scale gust from downdrafts of GF cumulus scheme
… gustiness and passive cloud volume. The namelist.atmosphere have now a new section under _gf_monan_.
…w option of grey zone deep convection configurations

@joaomas joaomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namelists - OK (DTN01 dont applied)

@joaomas joaomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discrepancies were found in the Code Review.

"DTN 01 - 4.6 - All programs, modules or procedures must have an implicit none declaration at the beginning"

It will require corrections from the developer.
Please check all new subroutines.

The Rules below will be ignored at this time and accepted.

"DTN 01 - 4.19 - As a general rule for constructing fonts, the indentation was defined with 4 (four) spaces. Do not use tabs for this purpose, as each editor can open the indentation with tabs in the wrong way. Defining an indentation leaves the clearest code."

"DTN 01 - 4.37 - The preferred mechanism for dynamic memory allocation is automatic arrays."

Please check the comments on the lines within the revised code.

Comment thread namelist_monan/GF_ConvPar_nml
Comment thread namelist_monan/namelist.atmosphere
Comment thread src/core_atmosphere/Registry.xml
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F Outdated
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F Outdated
Comment thread src/core_atmosphere/physics/physics_monan/module_bl_mixingscalars.F Outdated
@saulorfreitas

Copy link
Copy Markdown
Contributor Author

@deniseiras just delete it from this tag. It is now included in the new directory 'namelist_monan'.

@deniseiras deniseiras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All problems resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants