Skip to content

Conversation

@bazile-clyde
Copy link
Contributor

No description provided.

@bazile-clyde bazile-clyde requested a review from kevinAlbs July 17, 2020 21:17
}
if (main_view.find(el.key()) == main_view.end()) {
return false;
return el.get_value().type() == type::k_null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #695 into master will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   83.82%   83.61%   -0.21%     
==========================================
  Files         346      346              
  Lines       15959    16009      +50     
==========================================
+ Hits        13377    13386       +9     
- Misses       2582     2623      +41     
Impacted Files Coverage Δ
src/mongocxx/test_util/client_helpers.cpp 22.96% <0.00%> (ø)
src/mongocxx/options/index_view.cpp 47.61% <0.00%> (-25.11%) ⬇️
src/mongocxx/private/index_view.hh 84.31% <0.00%> (-12.24%) ⬇️
src/mongocxx/test/index_view.cpp 91.94% <0.00%> (-7.26%) ⬇️
src/mongocxx/index_view.cpp 95.23% <0.00%> (ø)
src/mongocxx/private/libmongoc_symbols.hh 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0b6e7...3e2a5ac. Read the comment docs.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bazile-clyde bazile-clyde merged commit b49ec57 into mongodb:master Jul 17, 2020
@bazile-clyde bazile-clyde deleted the CXX-2077 branch July 17, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants