allow underscore and capitals in Github token #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ping @rcsanchez97, is this something we should merge or close? |
Contributor
|
@kevinAlbs Strangely, I have no recollection of this PR. Even more
strangely, I have no recollection of #779, which is the same change for
the `releases/v3.6` branch, which I apparently closed without merging.
I think that Clyde requested my review since I was the original author
of the `make_release.py` script.
The change seems OK to me, though I don't execute the actual release
process, so is it OK if I toss this back to you? I have no objection to
the change, but you might make a note in the release checklist that this
change was made so that whomever makes future releases has a clue if
something related to this goes wrong.
|
kevinAlbs
approved these changes
Sep 15, 2021
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
I ran a quick test against my GitHub release token and LGTM.
kevinAlbs
pushed a commit
that referenced
this pull request
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script throws the error "No Github token found in file 'github_token.txt'" if the file contains a token with underscores and/or capital letters. This commit fixes that issue.