Skip to content

[DSD-9186]move images from dev2 to qa - #1350

Merged
Prafulrakhade merged 2 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Nov 6, 2025
Merged

[DSD-9186]move images from dev2 to qa#1350
Prafulrakhade merged 2 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated release deployment configuration with modified service components for improved build consistency.

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2025

Copy link
Copy Markdown

Walkthrough

The PR updates the vidivi release configuration by replacing a single Docker image entry (uitest-pmp-v2) with two new image entries (dsl-orchestrator and dsl-packetcreator) in the images list.

Changes

Cohort / File(s) Summary
Release configuration image update
release/vidivi/images.txt
Removes mosipdev2/uitest-pmp-v2:release-1.3.x entry and adds mosipdev2/dsl-orchestrator:release-1.3.x and mosipdev2/dsl-packetcreator:release-1.3.x entries

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A hop, skip, and orchestration dance,
Two new containers join the release's prance!
Dsl-creatures now bloom where one did bloom,
Clearing the old to make digital room. ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning Title mentions moving images from dev2 to qa, but the actual change replaces one image entry with two new entries (dsl-orchestrator and dsl-packetcreator), which is about replacing/adding images, not moving them between environments. Update title to accurately describe the change, e.g., 'Replace uitest-pmp image with dsl-orchestrator and dsl-packetcreator images in release-1.3.x' or clarify what 'move from dev2 to qa' means in this context.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38e5eb4 and 8c1ac4b.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (1)
release/vidivi/images.txt (1)

1-2: Verify registry move and functional change.

The PR title indicates moving images from dev2 to qa, but both images still reference the mosipdev2 registry (dev2), not a qa registry. Additionally, a single image (uitest-pmp-v2) is being replaced with two images (dsl-orchestrator and dsl-packetcreator), which is a functional change beyond a simple registry migration.

Clarify:

  1. Are these images intentionally staying in the dev2 registry, or should they be moved to a qa registry?
  2. Is replacing one image with two the intended behavior, or should the old image remain?
  3. Are dsl-orchestrator and dsl-packetcreator appropriate replacements for uitest-pmp-v2 in the qa environment?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prafulrakhade
Prafulrakhade merged commit c165a8f into mosip:release-1.2.0.1 Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants