Skip to content

[DSD-9417] move images from dev2 to qa - #1447

Merged
Prafulrakhade merged 2 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Dec 4, 2025
Merged

[DSD-9417] move images from dev2 to qa#1447
Prafulrakhade merged 2 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Edited image reference entries but resulted in no net change to container image tags or exported/public declarations; no functional impact observed.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Dec 4, 2025

Copy link
Copy Markdown

Walkthrough

No net functional change: release/vidivi/images.txt shows the same mosipdev2/dsl-packetcreator:release-1.3.x line removed and re-added, and the file ends without a trailing newline.

Changes

Cohort / File(s) Summary
Image file no-op edit
release/vidivi/images.txt
A single line mosipdev2/dsl-packetcreator:release-1.3.x was removed and re-added (no net change); file ends without a trailing newline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Inspect release/vidivi/images.txt to confirm the removal/addition are identical and the lack of newline is intentional.

Possibly related PRs

Suggested reviewers

  • Prafulrakhade
  • ckm007

Poem

🐰
I nudged a line, then nudged it back,
A quiet hop along the track.
Same footprint in the file I leave,
A tiny tweak — then take my leave. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'move images from dev2 to qa', but the raw summary shows no observable change to image entries and the patch shows removal and addition of the same line with no net difference. Verify if actual image migration occurred. If no net changes exist, update the title to reflect the actual state of changes, or clarify the intended changes in the PR description.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb1cd18 and c1056e8.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • release/vidivi/images.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b6b98e and bb1cd18.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (2)
release/vidivi/images.txt (2)

1-2: Verify image replacement and version compatibility.

The change replaces inji-certify-with-plugins:release-0.13.x with two new images (dsl-orchestrator and dsl-packetcreator) and bumps versions to 1.3.x. Please verify:

  1. That dsl-orchestrator and dsl-packetcreator are the correct functional replacements for inji-certify-with-plugins.
  2. That the version bump from 0.13.x to 1.3.x is intentional and compatible with other components.
  3. That there are no breaking changes introduced by this replacement.

1-2: No action needed — images were correctly transferred to mosipqa.

The images.txt format is source-image:source-tag destination-tag, where the first part specifies the source registry and the second part is the destination tag. The mosipdev2 reference indicates the source, not the destination. The transfer report confirms both images were successfully transferred to mosipqa registry as intended by the PR objective "[DSD-9417] move images from dev2 to qa".

Comment thread release/vidivi/images.txt Outdated
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@Prafulrakhade
Prafulrakhade merged commit 30e16c3 into mosip:release-1.2.0.1 Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants