[DSD-9264] mosipdev to mosipqa - #1394
Conversation
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
WalkthroughThis change updates the release configuration by replacing a single print service image entry with three new service image entries in the Vidivi release manifest, specifically adding partner-management-service, policy-management-service, and pmp-ui-v2 references with develop branch specifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| mosipdev/pmp-ui-v2:develop develop | ||
| mosipdev/partner-management-service:develop develop | ||
| mosipdev/policy-management-service:develop develop |
There was a problem hiding this comment.
🧩 Analysis chain
Critical: PR title states "mosipdev to mosipqa" but code uses "mosipdev" registry.
The PR title indicates a registry migration from mosipdev to mosipqa, but lines 1-3 still reference mosipdev. This is a significant discrepancy that suggests the intended changes may not have been applied.
Verify the intended changes:
- Did you mean to change
mosipdev→mosipqaacross all three image references? - If so, apply this diff:
-mosipdev/pmp-ui-v2:develop develop
-mosipdev/partner-management-service:develop develop
-mosipdev/policy-management-service:develop develop
+mosipqa/pmp-ui-v2:develop develop
+mosipqa/partner-management-service:develop develop
+mosipqa/policy-management-service:develop develop🏁 Script executed:
#!/bin/bash
# Check the actual content of the file and surrounding context
echo "=== File content: release/vidivi/images.txt ==="
cat release/vidivi/images.txt 2>/dev/null || echo "File not found"
echo -e "\n=== Directory listing of release/vidivi/ ==="
ls -la release/vidivi/ 2>/dev/null || echo "Directory not found"
echo -e "\n=== Git log for this file (last 5 commits) ==="
git log --oneline -5 -- release/vidivi/images.txt 2>/dev/null || echo "No git history available"
echo -e "\n=== Current git branch and PR info ==="
git branch -v 2>/dev/null || echo "No branch info"
git log -1 --format="%B" 2>/dev/null || echo "No commit message"
echo -e "\n=== Search for similar image manifest files ==="
find release -name "*.txt" -o -name "images*" 2>/dev/null | head -20 || echo "No other manifest files found"
echo -e "\n=== Search for mosipqa or mosipdev patterns in release directory ==="
rg "mosipqa|mosipdev" release/ 2>/dev/null | head -30 || echo "No patterns found"Length of output: 4811
Critical: PR title states "mosipdev to mosipqa" but code uses "mosipdev" registry—review comment is valid.
The verification confirms the original review comment is accurate. The commit message [DSD-9264] mosipdev to mosipqa indicates intent to migrate to the mosipqa registry, but the three image entries in lines 1-3 still reference mosipdev.
Additionally, the transfer report and logs show the previous release migrated the print service from mosipdev/print:release-1.3.x to mosipqa/print:1.3.x, establishing a pattern of using stable release tags (not develop branches) for release manifests. The current entries using develop tags on mosipdev registry contradicts both the PR objective and the established release pattern.
These entries require update to use the mosipqa registry and should likely use stable release tags instead of develop to maintain consistency with the prior release configuration.
🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1-3 the entries still reference the
mosipdev registry and use "develop" tags while the PR and commit message intend
migration to mosipqa and the release pattern requires stable release tags;
update each image entry to use the mosipqa registry (e.g., mosipqa/pmp-ui-v2,
mosipqa/partner-management-service, mosipqa/policy-management-service) and
replace "develop" tags with the appropriate stable release tags used in this
release (match the transfer report or prior-release tag format, e.g.,
release-<version> or the exact version numbers), ensuring the registry and tag
changes are applied to all three lines.
🧩 Analysis chain
Major: Using develop branches in release configuration.
Lines 1-3 reference the develop branch for all three services. This is atypical for release manifests because:
- Release stability: Develop branches are unstable and subject to frequent, unvetted changes. Release builds should lock to tagged, stable versions.
- Reproducibility: Using develop branches can result in non-deterministic builds, where the same release tag pulls different code at different times.
- Version control: Releases typically pin specific versions (e.g.,
release-1.3.x, as evidenced by the replaced print service entry).
Confirm whether this is intentional or whether these should reference release tags instead (e.g., release-1.2.0.1 to match the target branch).
If stable versions are required, consider updating to:
-mosipdev/pmp-ui-v2:develop develop
-mosipdev/partner-management-service:develop develop
-mosipdev/policy-management-service:develop develop
+mosipdev/pmp-ui-v2:release-1.2.0.1 release-1.2.0.1
+mosipdev/partner-management-service:release-1.2.0.1 release-1.2.0.1
+mosipdev/policy-management-service:release-1.2.0.1 release-1.2.0.1I'll help you verify this review comment. Let me gather information about the file structure and context.
---
🏁 Script executed:
```shell
#!/bin/bash
# Check the full content of the release configuration file
if [ -f "release/vidivi/images.txt" ]; then
echo "=== Full content of release/vidivi/images.txt ==="
cat "release/vidivi/images.txt"
echo ""
echo "=== Line count and details ==="
wc -l "release/vidivi/images.txt"
else
echo "File not found at release/vidivi/images.txt"
fi
Length of output: 247
🏁 Script executed:
#!/bin/bash
# Search for other release configuration files with similar pattern
echo "=== Searching for other release config files ==="
find release -type f -name "*.txt" 2>/dev/null | head -20
echo ""
echo "=== Searching for files with similar structure (service:branch patterns) ==="
rg -l "mosipdev|develop|release-" release/ --type txt 2>/dev/null | head -20Length of output: 283
🏁 Script executed:
#!/bin/bash
# Look for any documentation about versioning strategy
echo "=== Searching for version/branching documentation ==="
find . -maxdepth 3 -type f \( -name "README*" -o -name "RELEASE*" -o -name "VERSION*" \) 2>/dev/null | head -10Length of output: 234
---
🏁 Script executed:
```shell
#!/bin/bash
# Check the content of release/checks/images.txt for comparison
echo "=== Content of release/checks/images.txt ==="
cat "release/checks/images.txt"
echo ""
echo "=== Content of release/vidivi/README.md ==="
cat "release/vidivi/README.md"
Length of output: 16695
🏁 Script executed:
#!/bin/bash
# Check the main release README for branching/versioning strategy
echo "=== Content of release/README.md ==="
cat "release/README.md"Length of output: 6859
🏁 Script executed:
#!/bin/bash
# Search for git history or version tags pattern
echo "=== Searching for release tags or version patterns in code ==="
rg "release-[0-9]+" --max-count=5 . --type txt --type md 2>/dev/nullLength of output: 1606
Update references to use release version tags instead of develop branches.
The file is used by the image transfer tool as part of the official release process. The documented workflow expects images to be transferred using specific release versions, and the example format shown in the tool's documentation uses versioned tags (e.g., mosipdev/kernel-auth-service:1.2.0.1 1.2.0.1), not branch references. Using develop branches creates non-deterministic builds where the same release tag pulls different code over time.
Lines 1-3 should reference stable release tags:
-mosipdev/pmp-ui-v2:develop develop
-mosipdev/partner-management-service:develop develop
-mosipdev/policy-management-service:develop develop
+mosipdev/pmp-ui-v2:release-1.2.0.1 release-1.2.0.1
+mosipdev/partner-management-service:release-1.2.0.1 release-1.2.0.1
+mosipdev/policy-management-service:release-1.2.0.1 release-1.2.0.1📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| mosipdev/pmp-ui-v2:develop develop | |
| mosipdev/partner-management-service:develop develop | |
| mosipdev/policy-management-service:develop develop | |
| mosipdev/pmp-ui-v2:release-1.2.0.1 release-1.2.0.1 | |
| mosipdev/partner-management-service:release-1.2.0.1 release-1.2.0.1 | |
| mosipdev/policy-management-service:release-1.2.0.1 release-1.2.0.1 |
🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 3, the entries currently
reference the develop branch instead of stable release tags; update each line to
use the official release version tag in both the image tag and the second column
(format: <image>:<version> <version>) — replace "develop develop" with the
correct release version (e.g., 1.2.0.1 1.2.0.1) for each of mosipdev/pmp-ui-v2,
mosipdev/partner-management-service, and mosipdev/policy-management-service so
the image transfer tool pulls deterministic, versioned images.
2 participants
Summary by CodeRabbit