Skip to content

[DSD-9337] pmp-revamp 1.2.2.3 patch release - #1417

Merged
Prafulrakhade merged 1 commit into
release-1.2.0.1from
Prafulrakhade-patch-8
Nov 26, 2025
Merged

[DSD-9337] pmp-revamp 1.2.2.3 patch release#1417
Prafulrakhade merged 1 commit into
release-1.2.0.1from
Prafulrakhade-patch-8

Conversation

@Prafulrakhade

@Prafulrakhade Prafulrakhade commented Nov 26, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated deployment image configuration with new partner and policy management service components, migrated to version 1.2.2.3.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 26, 2025

Copy link
Copy Markdown

Walkthrough

The pull request replaces a single container image entry in the release configuration with seven new image entries, updating the dataset from mosipdev2/uitest-admin:release-1.3.x to multiple mosipdev/* images tagged with release-1.2.2.x. This is a purely data-level change with no logic modifications.

Changes

Cohort / File(s) Summary
Configuration data update
release/vidivi/images.txt
Replaced single image entry (mosipdev2/uitest-admin:release-1.3.x 1.3.x) with seven new mosipdev/* image entries (partner-management-service, policy-management-service, apitest-pms, pmp-ui, pmp-revamp-ui, uitest-pmp, pmp-revamp-ui) all tagged with release-1.2.2.x 1.2.2.3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • This is a straightforward data replacement in a configuration file with no logic or error handling changes involved.

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 One old image fades away,
Seven new ones light the day!
From 1.3.x to 1.2.2.3,
Partner paths and policies free!
Config hops to a brighter way. 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates this is a patch release for pmp-revamp version 1.2.2.3, which aligns with the changes that replace old image entries with new pmp-related services at version 1.2.2.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Prafulrakhade-patch-8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82e2ad5 and 1625606.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)

Comment thread release/vidivi/images.txt
Comment on lines +5 to +7
mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3
mosipdev/uitest-pmp:release-1.2.2.x 1.2.2.3
mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Remove duplicate image entry.

Lines 5 and 7 both declare mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3. This duplicate entry could cause issues with deployment automation or version tracking scripts.

Apply this diff to remove the duplicate:

 mosipdev/pmp-ui:release-1.2.2.x 1.2.2.3
 mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3
-mosipdev/uitest-pmp:release-1.2.2.x 1.2.2.3
-mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3
+mosipdev/uitest-pmp:release-1.2.2.x 1.2.2.3

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 5 to 7 there is a duplicate entry for
mosipdev/pmp-revamp-ui:release-1.2.2.x 1.2.2.3 (appearing on lines 5 and 7);
remove the duplicate (delete the line at 7) so each image appears only once,
preserving the other distinct entries and keeping file ordering intact.

@Prafulrakhade
Prafulrakhade merged commit 56b05db into release-1.2.0.1 Nov 26, 2025
5 checks passed
@Prafulrakhade
Prafulrakhade deleted the Prafulrakhade-patch-8 branch December 10, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant