Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed moveit_jog_arm for renaming and relocating #203

Closed
wants to merge 1 commit into from

Conversation

AdamPettinger
Copy link
Contributor

Description

This PR only removes moveit_jog_arm from the moveit_experimental folder. The intent is to add it back soon with a different name (likely moveit_servo) in a new location (likely moveit_ros), and do all jogger related ROS2 transitioning and improvement work there with direction from @AndyZe and @tylerjw

I would think this PR will stay open until jog_arm is added back in, and I will link to that when it happens. Just wanted to give some time for naming and location feedback first 😃

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@henningkayser
Copy link
Member

@AdamPettinger Thanks for starting this! I think that we should sync the latest (pending) progress from MoveIt 1 once the PR's are merged and make sure to keep the history when renaming/moving this package. In general, are you planning to work in a feature branch and file PRs for milestones or would you rather keep on adding frequent changes to master?

@AdamPettinger
Copy link
Contributor Author

I think that we should sync the latest (pending) progress from MoveIt 1 once the PR's are merged and make sure to keep the history when renaming/moving this package.

Sounds like a good plan, although I don't know the actual mechanisms of doing that. In that case, this PR will probably be rebased after that pending progress is merged, and expanded to include the renaming and relocation as well.

In general, are you planning to work in a feature branch and file PRs for milestones or would you rather keep on adding frequent changes to master?

I have not decided yet, but if one is definitively easier for maintainers/reviewers, let's do that one.

@AdamPettinger
Copy link
Contributor Author

@henningkayser I think I will be ready to start with the ROS2 side soon.

I discussed with @AndyZe and @tylerjw, and they thought the best approach might be to just copy the most recent version of jog_arm from the ROS1 work and push it here, and not worry too much about the git history. Is that something you're comfortable with? If not, how do we get the changes to here with git history?

@henningkayser
Copy link
Member

@henningkayser I think I will be ready to start with the ROS2 side soon.

I discussed with @AndyZe and @tylerjw, and they thought the best approach might be to just copy the most recent version of jog_arm from the ROS1 work and push it here, and not worry too much about the git history. Is that something you're comfortable with? If not, how do we get the changes to here with git history?

@AdamPettinger I would prefer to use a filtered merge for this and keep the history consistent.
Can you do this after moveit/moveit#2151 is merged?

@AdamPettinger
Copy link
Contributor Author

@henningkayser I think I did it with #221, please verify that. If it looks good, I will rebase this PR on top of that and add commits to move the files instead of just deleting them

@henningkayser
Copy link
Member

continued in #221 #222

@AdamPettinger AdamPettinger deleted the remove_jog_arm branch August 24, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants