Support parallel_gripper_action_controller in Setup Assistant (#3752)#3773
Merged
Conversation
* Support parallel_gripper_action_controller in Setup Assistant moveit_resources migrated the gripper from position_controllers/ GripperActionController (Humble/Iron) to parallel_gripper_action_controller/ GripperActionController (Jazzy and newer). Both are single-joint GripperActionControllers that take a `joint` parameter. Teach moveit_setup_controllers to recognize the new type: - ros2_controllers_config: emit the `joint` (singular) parameter for either gripper controller type, instead of only the old one (the old check misclassified the new type and emitted a `joints` list). - ros2_controllers: offer the new type in getAvailableTypes(). - test_controllers (ParsePanda): accept either gripper type so the test is distro-agnostic (the panda config now ships the Jazzy+ type). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address review: guard gripper joint index, add panda gripper output test - ros2_controllers_config: only write the singular `joint` parameter when the gripper controller actually has a joint, so joints_[0] is never indexed out of bounds for a gripper with an empty joint list. - test_controllers: add OutputPandaGripperUsesSingularJoint, which generates the panda ros2_controllers.yaml and asserts the GripperActionController is emitted with the singular `joint` key (not the `joints` list) -- coverage the gripper-less OutputFanuc test could not provide. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Please target the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jazzy #3773 +/- ##
==========================================
+ Coverage 0.00% 46.25% +46.25%
==========================================
Files 294 718 +424
Lines 28361 59184 +30823
Branches 3964 7598 +3634
==========================================
+ Hits 0 27369 +27369
- Misses 28361 31649 +3288
- Partials 0 166 +166 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moveit_resources migrated the gripper from position_controllers/ GripperActionController (Humble/Iron) to parallel_gripper_action_controller/ GripperActionController (Jazzy and newer). Both are single-joint GripperActionControllers that take a
jointparameter.Teach moveit_setup_controllers to recognize the new type:
joint(singular) parameter for either gripper controller type, instead of only the old one (the old check misclassified the new type and emitted ajointslist).jointparameter when the gripper controller actually has a joint, so joints_[0] is never indexed out of bounds for a gripper with an empty joint list.jointkey (not thejointslist) -- coverage the gripper-less OutputFanuc test could not provide.Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist