Cleanup install rules#358
Merged
rhaschke merged 3 commits intomoveit:melodic-develfrom Jul 11, 2019
Merged
Conversation
This library contains helpers for the tutorials only. It is not meant to be a public interface as the tutorials do not provide any guarantees of API stability (for obvious reasons).
rhaschke
approved these changes
Jul 11, 2019
rhaschke
pushed a commit
that referenced
this pull request
Jul 11, 2019
* install missing launch folders * install missing binaries * install, but do not expose libinteractivity_utils This lib is not meant as a public interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @timjrobinson pointed out in #355, some launch folders did not get installed before.
Looking through the build instructions, some other targets were missing too.
Notably,
libinteractivity_utils.sogot installed to/share/(and thus broke binaries that depend on it in an install workspace). I decided to remove the library, which was not properly installed anyway, from all public interfaces, because we do not want to provide stable API in the tutorials package - Nobody should need to depend on it in the first place.Should be merged in master too. I targeted
melodic-develbecause that's the branch @timjrobinson used.Replaces #355.