Skip to content

Fix the order of planning_adapters#511

Merged
v4hn merged 2 commits intomoveit:masterfrom
tnaka:patch-1
Aug 10, 2020
Merged

Fix the order of planning_adapters#511
v4hn merged 2 commits intomoveit:masterfrom
tnaka:patch-1

Conversation

@tnaka
Copy link
Copy Markdown
Contributor

@tnaka tnaka commented Aug 9, 2020

Description

Fix the order of planning_adapters.
Add TimeParameterization should be on the top of the list.
See moveit/moveit#2053

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

tnaka added 2 commits August 10, 2020 04:28
Fix the order of planning_adapters.
Add TimeParameterization should be on the top of the list.
See moveit/moveit#2053
@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 9, 2020

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Copy Markdown
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's annoying that there are so many places where this was wrong... Thank you for the cleanup @tnaka !

@v4hn v4hn merged commit fa4595a into moveit:master Aug 10, 2020
@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 10, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants