Skip to content

Add version buttons and indicator in sidebar header#557

Merged
mamoll merged 3 commits intomoveit:masterfrom
auman66:version-buttons
Dec 31, 2020
Merged

Add version buttons and indicator in sidebar header#557
mamoll merged 3 commits intomoveit:masterfrom
auman66:version-buttons

Conversation

@auman66
Copy link
Copy Markdown
Contributor

@auman66 auman66 commented Nov 19, 2020

Description

Added a version drop-down menu to the top of the nav bar. Also updated wording for version notice at top.

Version pop-out at bottom of sidebar was also updated, but is not being used right now.
If this gets merged I can add the same thing to older versions of documentation.

version-dropdown

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@auman66 auman66 marked this pull request as draft November 19, 2020 19:29
@auman66 auman66 changed the title add version buttons and indicator in sidebar header WIP: add version buttons and indicator in sidebar header Nov 19, 2020
@auman66 auman66 changed the title WIP: add version buttons and indicator in sidebar header Add version buttons and indicator in sidebar header Dec 1, 2020
@auman66 auman66 marked this pull request as ready for review December 1, 2020 22:18
Comment thread _themes/sphinx_rtd_theme/moveit_version.html Outdated
@davetcoleman
Copy link
Copy Markdown
Member

Can you add some text to the left of the drop down with a caption like "Version: " in case beginners don't know what Melodic etc means?

@auman66
Copy link
Copy Markdown
Contributor Author

auman66 commented Dec 4, 2020

How is this:
image

Alex Goldman and others added 3 commits December 29, 2020 09:31
Updated wording on version notification.
Update theme version popout at bottom of page (not used).
Co-authored-by: Nathan Brooks <nbbrooks@gmail.com>
@mamoll mamoll merged commit 71ecd2d into moveit:master Dec 31, 2020
Abishalini pushed a commit to Abishalini/moveit_tutorials that referenced this pull request Apr 29, 2021
* Add version dropdown to top of sidebar.
Updated wording on version notification.
Update theme version popout at bottom of page (not used).

* Update _themes/sphinx_rtd_theme/moveit_version.html

Co-authored-by: Nathan Brooks <nbbrooks@gmail.com>

* add lable to dropdown

Co-authored-by: Nathan Brooks <nbbrooks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants