Update secure_url to match protocol of current page. Bug 901523.#1136
Merged
pmclanahan merged 1 commit intomozilla:masterfrom Aug 7, 2013
Merged
Update secure_url to match protocol of current page. Bug 901523.#1136pmclanahan merged 1 commit intomozilla:masterfrom
pmclanahan merged 1 commit intomozilla:masterfrom
Conversation
bedrock/mozorg/helpers/misc.py
Outdated
Contributor
There was a problem hiding this comment.
It'd be more readable to use the more traditional if block.
Contributor
|
Also jenkins failed. Apart from those things I like this. |
Contributor
Author
|
Oh yeah, tests. I should update those. I'll also update to a standard if block and update. |
Contributor
Author
|
@pmclanahan r? |
pmclanahan
pushed a commit
that referenced
this pull request
Aug 7, 2013
Update secure_url to match protocol of current page. Bug 901523.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AJAX requests will error out when being made from HTTP to HTTPS. CSRF protected forms require protocols to match.
Longer term solution (forcing all of mozilla.org to be HTTPS) is in the works. This is a passive patch to immediately fix HTTP to HTTPS errors introduced in PR 928 (#928).