Bug 1119312: Upgrade Django to 1.6.9#2634
Closed
pmclanahan wants to merge 2 commits intomozilla:masterfrom
Closed
Conversation
Also fixes some tests that were failing after upgrade. Code was relying on Django's strip_tags filter which has changed and now ignores things that obviously aren't HTML tags Updated to latest playdoh-lib which includes fixes for Django 1.6 in funfactory.
pmclanahan
force-pushed
the
upgrade-django-1.6-1119312
branch
from
914c8c8 to
e8c9502
Compare
Merged
Contributor
There was a problem hiding this comment.
We should not do this: https://docs.djangoproject.com/en/1.7/ref/templates/builtins/#striptags
Contributor
Author
There was a problem hiding this comment.
Why not? This is a text email? It's what we've been doing and seems fine.
Contributor
There was a problem hiding this comment.
It's probably fine in a plain text email , but there have been issues in the past where certain combinations of email client or web mail clients would ignore MIME types. That said, the recipients of these particular emails are highly unlikely to be using ancient versions of outlook express (at least I hope so!), so my knee-jerk reaction was probably a little strong given the context.
Contributor
|
Closing this in favor of #2635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes some tests that were failing after upgrade.
Code was relying on Django's strip_tags filter which has
changed and now ignores things that obviously aren't HTML tags
Updated to latest playdoh-lib which includes fixes for Django 1.6
in funfactory.
@jgmize r?