Skip to content

Redirect outdated /contribute pages (Fixes #6994)#7126

Merged
alexgibson merged 1 commit into
mozilla:masterfrom
alexgibson:redirect-contribute
May 7, 2019
Merged

Redirect outdated /contribute pages (Fixes #6994)#7126
alexgibson merged 1 commit into
mozilla:masterfrom
alexgibson:redirect-contribute

Conversation

@alexgibson

@alexgibson alexgibson commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

Description

Issue / Bugzilla link

#6994

Testing

  • Check I didn't miss any stray unused assets?
  • Check internal links to /signup are all updated?

Successful test run: https://ci.vpn1.moz.works/blue/organizations/jenkins/bedrock_multibranch_pipeline/detail/run-integration-tests/302/pipeline

@craigcook craigcook self-assigned this Apr 30, 2019
@alexgibson alexgibson added P2 Second level priority - Should have Review: S Code review time: 30 mins to 1 hour labels Apr 30, 2019
@alexgibson alexgibson added the Needs Review Awaiting code review label Apr 30, 2019

@craigcook craigcook left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but it needs a rebase (just static-bundles.json, really). Though it's still marked as a draft so was there something else you needed to do? If not then feel free to merge after you rebase. r+ 📐

@alexgibson
alexgibson marked this pull request as ready for review May 7, 2019 08:07
@alexgibson

Copy link
Copy Markdown
Contributor Author

Rebased 🎉

@alexgibson
alexgibson merged commit 7aebcd0 into mozilla:master May 7, 2019
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Oct 16, 2019
@alexgibson
alexgibson deleted the redirect-contribute branch November 15, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Second level priority - Should have Review: S Code review time: 30 mins to 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants