implementation of Firefox OS privacy policy for display on device#799
implementation of Firefox OS privacy policy for display on device#799ghost wants to merge 1 commit intomozilla:masterfrom schalkneethling:bug820212-implement-ffos-privacy-policy
Conversation
|
@Sancus r? |
There was a problem hiding this comment.
add role="main" here. It's a bit redundant but the main element is new enough that most screen readers don't recognize it yet but do support the ARIA role.
|
Will this page be English only? None of the strings are marked for extraction and localization. If we ever intend to translate this page we should go ahead and plan for it now, even if it's en-US-only for the first release. |
There was a problem hiding this comment.
strings should be wrapped for l10n.
There was a problem hiding this comment.
[18:03] [sancus] espressive: also is there a reason that the url is /privacy/firefox-os and not /privacy/policies/firefox-os in the same pattern as literally every other url in that app?
[18:04] [espressive] sancus: yes, it is because the entry point inside the FTU app on FirefoxOS has the entry point for the policy set-up as such
There was a problem hiding this comment.
We should put the page in the right spot, add a redirect for their bad URL, and file a bug for them to fix it.
|
Policies and legal information are typically en-US only. |
|
@craigcook So I was wondering about the l10n issue. Currently there is a discussion going on and it seems there is no clear decision on whether it will be translated or not but I reckon, to be safe, let me l10n this anyway. |
|
URL is now privacy/policies/firefox-os so we only need the redirect to be implemented until the bug is fixed in Gaia to point to this URL. Not sure where to do this. @pmclanahan ? |
There was a problem hiding this comment.
should be a raw string, end with a / and match the other regexes: r'^/policies/firefox-os/$'. I also think the name should be 'privacy.firefoxos'. Not sure why the facebook one has a / in it...
|
was merged manually by pmac 226c34b with redirect added and commit message fixed. |
|
Thanks @Sancus |
4 participants
@pmac r?