Skip to content

Bug 860532 porting governance, policies, roles and organizations to bedr...#836

Merged
sgarrity merged 1 commit into
mozilla:masterfrom
retornam:bug-860532-port-governance
Jun 14, 2013
Merged

Bug 860532 porting governance, policies, roles and organizations to bedr...#836
sgarrity merged 1 commit into
mozilla:masterfrom
retornam:bug-860532-port-governance

Conversation

@retornam

@retornam retornam commented May 7, 2013

Copy link
Copy Markdown
Contributor

...ock

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty href?

@ghost ghost assigned sgarrity May 9, 2013
@retornam

Copy link
Copy Markdown
Contributor Author

I've re-based this with changes from the bedrock upgrade

@sgarrity

Copy link
Copy Markdown
Contributor

The template files need to move into the new playdoh dir structure. For example:

apps/mozorg/templates/mozorg/about/governance/governance.html -> bedrock/mozorg/templates/mozorg/about/governance/governance.html

@retornam

Copy link
Copy Markdown
Contributor Author

@sgarrity updated

@sgarrity

Copy link
Copy Markdown
Contributor

Technically, this port of these pages looks good. The navigation is getting confusing though. There is a "Governance" item in the right menu on about pages, but then the Governance sub-pages are not reflected in the navigation.

That said, I don't think the URLs would need to change to improve this situation, so we could probably merge this and file another bug to clarify the /about/* page navigation.

@sgarrity

Copy link
Copy Markdown
Contributor

I haven't looked through all pages yet, but on the Organizations page, at least, there are a variety of typos, capitalization changes, and missing punctuation that aren't in the original version.

@retornam

Copy link
Copy Markdown
Contributor Author

updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the dash in Super-Reviewers removed intentionally?

@retornam

Copy link
Copy Markdown
Contributor Author

@sgarrity I have updated this based on your review. For the 404 urls I have filed bugs to ask if they can be removed.
Thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants