fix(yarn): stop Yarn Berry hijacking the bump env vars - #151
Open
toufali wants to merge 1 commit into
Open
Conversation
This was referenced Sep 4, 2026
The yarn bump step passed the target package via YARN_PACKAGE/YARN_VERSION. Yarn Berry reads any YARN_<NAME> env var as a config setting, so every yarn call in yarn-fix.sh failed with 'Unrecognized configuration settings: package' — 'yarn up' never ran and no bump PR was ever opened (silent, on every yarn remediation). Rename them to BUMP_PACKAGE/BUMP_VERSION.
toufali
force-pushed
the
fix/yarn-bump-env-collision
branch
from
September 4, 2026 21:27
e49da83 to
a25fb56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
BLEnder's yarn-bump remediation has been silently failing on every yarn (Berry) repo, so it never opened a bump PR. Yarn Berry reads any
YARN_<NAME>environment variable as a config setting; the bump step passed the target viaYARN_PACKAGE/YARN_VERSION, so everyyarncall inyarn-fix.shaborted with:yarn upnever ran → resolution fallback found no change → "nothing to open". No error surfaced anywhere except the run log.Evidence
mozilla/fxa alert #913 (@simplewebauthn/server), run 33902016880: verdict
not affected / bump_pr, then the Usage Error above and "no changes produced … nothing to open."Fix
Rename the env vars to
BUMP_PACKAGE/BUMP_VERSION(off theYARN_prefix) in the workflow step andyarn-fix.sh, with a note so nobody reintroduces aYARN_*name.Closes #152