use settings_travis.js when running tests locally (bug 1047109)#544
use settings_travis.js when running tests locally (bug 1047109)#544cvan wants to merge 1 commit into
settings_travis.js when running tests locally (bug 1047109)#544Conversation
There was a problem hiding this comment.
Would be good if the test command fails this line is always run so you don't get stuck with unexpected settings.
There was a problem hiding this comment.
Is there no better way we can independently supply settings? Maybe have a settings data attr in the damper served page that overrides any settings here?
There was a problem hiding this comment.
I like the idea of having a data attr containing a settings object that can override the settings file. We've done that in webpay for a while and we do it in Spartacus too. It works quite nicely and means you can put more service settings in one place.
There was a problem hiding this comment.
how exactly would you do this? put it in src/app.html, src/index.html, and Zamboni's commonplace/index.html?
There was a problem hiding this comment.
I'd start by just putting it where it's needed to start with. In this case we just need damper's html page to override the settings for tests. If we need to override settings from zamboni we can add that to the zamboni html later.
There was a problem hiding this comment.
can you guys explain to me how exactly that would work? like precisely? thanks
|
Should we close this pending the feedback? |
4 participants
https://bugzilla.mozilla.org/show_bug.cgi?id=1047109