This repository was archived by the owner on Mar 15, 2018. It is now read-only.
refresh feedback modal (bug 1103230) - #868
Merged
Merged
Conversation
ngokevin
force-pushed
the
feed-feedbackmodal
branch
from
December 22, 2014 20:07
f832ed1 to
13cd03d
Compare
ngokevin
force-pushed
the
feed-feedbackmodal
branch
3 times, most recently
from
December 23, 2014 08:58
752da7d to
360cbd2
Compare
ngokevin
force-pushed
the
feed-feedbackmodal
branch
from
December 23, 2014 23:36
360cbd2 to
494ed7f
Compare
Contributor
There was a problem hiding this comment.
I thought this toggles the "overflowed" class which basically sets a body {overflow: hidden} for the modal background mask ("cloak").
Contributor
Author
There was a problem hiding this comment.
trying to deprecate the whole cloak thing. it requires an element pre-defined in our super base commonplace template and setting a class (with an ambiguous name) on a separate element. everything is encapsulated within a custom HTML element now
Contributor
|
Haven't tested this locally but nothing in it seems too radical. r+ thanks. |
Contributor
Author
|
thanks, although it should be pretty required for reviewers to apply frontend patches locally. else you'd be reviewing it blind. |
ngokevin
force-pushed
the
feed-feedbackmodal
branch
from
January 6, 2015 14:37
494ed7f to
055a194
Compare
ngokevin
added a commit
that referenced
this pull request
Jan 6, 2015
refresh feedback modal (bug 1103230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mozilla/marketplace-elements#4
todo: tests