This repository was archived by the owner on Mar 15, 2018. It is now read-only.
Fix blocked payment window (1122243)#914
Merged
muffinresearch merged 2 commits intoJan 16, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Just a nit but I think it would be better to call this as payments.openWindow() and then define it in the exports as {..., openWindow: fxpay.utils.openWindow}.
Contributor
Author
There was a problem hiding this comment.
The downside of this is that the context is then wrong for the defaults usage [1] (a bug in itself). I'll leave this as is and fix that up next week along with the default url.
[1] https://github.com/mozilla/fxpay/blob/master/lib/fxpay/utils.js#L51
Contributor
|
This is a temporary solution. Off the thread we discussed a better solution here: https://etherpad.mozilla.org/fireplace-pay-popup-madness |
Contributor
|
r+wc |
muffinresearch
added a commit
that referenced
this pull request
Jan 16, 2015
…-1122243 Fix blocked payment window (1122243)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This opens a popup for the payment when logged out. This is done as part of the click to the button so the popup isn't blocked.. The login window will then sit over the top of this.
If the login fails the payment window will be closed too.
This can't close the payment window when the login window is closed because afaict the deferred login isn't being rejected in this scenario.
r? @kumar303