Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b54fc50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
|
🥴 I thought I confirmed the string extraction test failure was no longer an issue here but I'm not seeing that it was ran. I'll take a closer look at it tomorrow. |
|
🎉 Huzzah, edit: see #15571, once that's merged I will revert some of these changes and rebase |
bcolsson
left a comment
There was a problem hiding this comment.
From what I can tell, only text is being removed. So approving. (Please let me know if I'm overlooking something.)
Also, thanks for finding the source of the error in the action script!
Because: * Now that we've rolled out the simple routes to 100%, we want to clean up the remaining backbone code. This commit: * Removes all mustache files associated with the simple routes (cannot_create_account, clear_storage, cookies_disabled, legal, and tos) * Removes all view js files (cannot_create_account, clear_storage, cookies_disabled, tos) * Removes all test spec files (cannot_create_account, clear_storage, cookies_disabled, tos) * Removes references to the Backbone views from the router file Closes #FXA-7398 Co-authored-by: Lauren Zugai <lauren@zugai.com>

Because:
This commit:
Closes FXA-7398
The original PR for this was here. I've opened this one to get a fresh review. I also filed this ticket in case we want to build these pages similarly.