Skip to content

chore(content-server): clean up backbone code for simple routes#15561

Merged
LZoog merged 1 commit intomainfrom
FXA-7398
Aug 1, 2023
Merged

chore(content-server): clean up backbone code for simple routes#15561
LZoog merged 1 commit intomainfrom
FXA-7398

Conversation

@LZoog
Copy link
Contributor

@LZoog LZoog commented Jul 20, 2023

Because:

  • Now that we've rolled out the simple routes to 100%, we want to clean up the remaining backbone code.

This commit:

  • Removes all mustache files associated with the simple routes (cannot_create_account, clear_storage, cookies_disabled, legal, and tos)
  • Removes all view js files (cannot_create_account, clear_storage, cookies_disabled, tos)
  • Removes all test spec files (cannot_create_account, clear_storage, cookies_disabled, tos)
  • Removes references to the Backbone views from the router file

Closes FXA-7398


The original PR for this was here. I've opened this one to get a fresh review. I also filed this ticket in case we want to build these pages similarly.

@nx-cloud
Copy link

nx-cloud bot commented Jul 20, 2023

@LZoog
Copy link
Contributor Author

LZoog commented Jul 20, 2023

🥴 I thought I confirmed the string extraction test failure was no longer an issue here but I'm not seeing that it was ran. I'll take a closer look at it tomorrow.

@clouserw
Copy link
Member

image
😍

@clouserw clouserw requested a review from a team July 21, 2023 23:21
@LZoog
Copy link
Contributor Author

LZoog commented Jul 21, 2023

🎉 Huzzah, fxa-l10n was successfully added by the script after tracking down the issue (commented in script). I'm going to open a separate PR for it and once it's merged I'll rebase here.

edit: see #15571, once that's merged I will revert some of these changes and rebase

Copy link
Contributor

@bcolsson bcolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, only text is being removed. So approving. (Please let me know if I'm overlooking something.)

Also, thanks for finding the source of the error in the action script!

Because:

* Now that we've rolled out the simple routes to 100%, we want to clean
  up the remaining backbone code.

This commit:

* Removes all mustache files associated with the simple routes
  (cannot_create_account, clear_storage, cookies_disabled, legal, and
tos)

* Removes all view js files (cannot_create_account, clear_storage,
  cookies_disabled, tos)

* Removes all test spec files (cannot_create_account, clear_storage,
  cookies_disabled, tos)

* Removes references to the Backbone views from the router file

Closes #FXA-7398

Co-authored-by: Lauren Zugai <lauren@zugai.com>
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZoog Very nice!

@LZoog LZoog merged commit 98c0dff into main Aug 1, 2023
@LZoog LZoog deleted the FXA-7398 branch August 1, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants