fix(ci): Capture grep -q exit code 1 to fix string extraction job#15571
Merged
fix(ci): Capture grep -q exit code 1 to fix string extraction job#15571
Conversation
Because: * Our string extraction CI job is failing when changes are found and l10n-devs has not been requested for review yet This commit: * Captures grep exit code to compare against directly, as grep -q "fxa-l10n" was failing and breaking out of the command pipeline with exit code 1
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ee83be9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
bcolsson
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
A different fix was made previously, as it appeared to least at least fix the job in this case. Looks like that worked for when fxa-l10n was already added, but I didn't realize I'd neglected to test the case where l10n hadn't been requested yet.
I hit that case in #15561 - this change is in that branch at the time of writing to show its success, see CI job under "Extract gettext and flag for review."