Merged
Conversation
This was referenced Sep 17, 2025
vpomerleau
approved these changes
Sep 18, 2025
Because: - The return type must be of type session token, or down stream code can fail This commit: - Avoids spreading the sessionToken object - Ensures the original sessionToken object is returned - Uses errors consistent with sessionToken auth strategy, ie AppError.unauthorized This was detected, because the authenticatorAssuranceLevel was undefined on the credentials object returned by the mfa auth strategy.
dschom
force-pushed
the
bug-fix-mfa-strategy-return-type
branch
from
8390095 to
31f4377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
auth.credentialswas populated by themfaauth strategy, downstream code would fail ifauthenticatorAssuranceLevelwas accessed.This pull request
mfaauth strategy.Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that apply