Skip to content

bug(many): Fix broken jest ui test runner#19949

Merged
dschom merged 1 commit intomainfrom
fix-ui-test-runner
Jan 27, 2026
Merged

bug(many): Fix broken jest ui test runner#19949
dschom merged 1 commit intomainfrom
fix-ui-test-runner

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Jan 27, 2026

Because

  • The jest UI test runner in VSCODE was broken.

This pull request

  • Fixes the test runner, for nx libs anyways.

Issue that this pull request solves

Closes: FXA-12958

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Copy link
Copy Markdown
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschom
Copy link
Copy Markdown
Contributor Author

dschom commented Jan 27, 2026

Restarted the functional tests, seems unrelated to these changes https://fxtrace.vercel.app/?url=https://output.circle-artifacts.com/output/job/e91882eb-31c2-4c86-960f-607b865c408e/artifacts/3/artifacts/functional/settings-replace2fa-severi-c57b1-and-old-2FA-should-not-work-local/trace.zip

Functional tests passed. This PR shouldn't impact that, so must have been a flake.

@dschom dschom merged commit c32fa39 into main Jan 27, 2026
20 checks passed
@dschom dschom deleted the fix-ui-test-runner branch January 27, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants