fix(settings): Top content hidden on mobile#20141
Merged
vpomerleau merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Because: - Without viewport-fit=cover, browsers do not expose env(safe-area-inset-*) values to the page, causing content to render under the status bar or notch in embedded webview contexts - The sticky header would pin beneath the native chrome on scroll without a matching safe area offset This commit: - Adds viewport-fit=cover to the viewport meta tag to unlock safe area inset values on iOS and Android - Adds padding-top: env(safe-area-inset-top) to body to keep content below the status bar on page load - Updates the sticky header's top offset to env(safe-area-inset-top) so it remains visible below the notch when scrolling Closes #FXA-13203
vbudhram
approved these changes
Mar 5, 2026
Contributor
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
I didn't test this on a device but seems low risk.
| data-testid="header" | ||
| role="banner" | ||
| className={props.className || 'sticky top-0 bg-grey-10 z-10'} | ||
| // top-[env(safe-area-inset-top)] keeps the sticky header below the notch/status bar on scroll |
Contributor
Author
There was a problem hiding this comment.
It was tricky to test, this seemed to only be an issue for VPN. We'll probably have to test on stage to confirm it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13203
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.