Skip to content

fix(settings): Top content hidden on mobile #20141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vpomerleau merged 1 commit into from
Mar 9, 2026
Merged

fix(settings): Top content hidden on mobile #20141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/fxa-react/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ export const Header = (props: HeaderProps) => {
<header
data-testid="header"
role="banner"
className={props.className || 'sticky top-0 bg-grey-10 z-10'}
// top-[env(safe-area-inset-top)] keeps the sticky header below the notch/status bar on scroll
Copy link
Copy Markdown
Contributor

@vbudhram vbudhram Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Copy Markdown
Contributor Author

@vpomerleau vpomerleau Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tricky to test, this seemed to only be an issue for VPN. We'll probably have to test on stage to confirm it works.

className={
props.className ||
'sticky top-[env(safe-area-inset-top)] bg-grey-10 z-10'
}
style={props.styles}
>
<div className="px-6 tablet:px-8 py-4 flex justify-between">
Expand Down
3 changes: 2 additions & 1 deletion packages/fxa-settings/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
<meta name="description" content="" />
<meta name="referrer" content="origin" />
<meta name="robots" content="noindex,nofollow" />
<!-- viewport-fit=cover exposes env(safe-area-inset-*) values for notch/status bar support on iOS and Android -->
<meta name="viewport"
content="width=device-width,initial-scale=1,minimum-scale=1,maximum-scale=2,user-scalable=yes" />
content="width=device-width,initial-scale=1,minimum-scale=1,maximum-scale=2,user-scalable=yes,viewport-fit=cover" />
<meta name="fxa-config" content="__SERVER_CONFIG__" />

__AUTH_URL_PRECONNECT__
Expand Down
2 changes: 2 additions & 0 deletions packages/fxa-settings/src/styles/tailwind.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

body {
@apply text-base font-body bg-grey-10 text-grey-900;
/* Prevent content from rendering under the status bar/notch on devices with display cutouts */
padding-top: env(safe-area-inset-top);
}

.nav-anchor {
Expand Down
Loading