Skip to content

chore(settings): replace esbuild with tsc/ts-node in packages/fxa-settings#20447

Merged
dschom merged 1 commit intomainfrom
esbuild-removal/settings
May 4, 2026
Merged

chore(settings): replace esbuild with tsc/ts-node in packages/fxa-settings#20447
dschom merged 1 commit intomainfrom
esbuild-removal/settings

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Apr 23, 2026

Split of #20390 into per-folder PRs. Scope: packages/fxa-settings.

Because

  • We want to test & develop with what we deploy.

This pull request

Issue that this pull request solves

Closes: FXA-13589

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

Screenshots (Optional)

Other information (Optional)

…tings

Because:
- We want to test & develop with what we deploy.

This commit:
- Part of the esbuild -> tsc/ts-node migration (split of a6d1a55, PR #20390).
- Scope: files under packages/fxa-settings (including deletion of deriver.ts).
@dschom dschom requested a review from a team as a code owner April 23, 2026 19:52

describe('thirdPartyAuth', () => {
it('submits a ping with the third_party_auth_google_reg_start event name', async () => {
GleanMetrics.initialize(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes flaky test?

@dschom dschom merged commit a78e4d6 into main May 4, 2026
21 checks passed
@dschom dschom deleted the esbuild-removal/settings branch May 4, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants