Skip to content

[Bug 1083914] Added Datepicker to Create announcement on l10n dashboard#2643

Merged
rehandalal merged 1 commit into
mozilla:masterfrom
anushbmx:master
Sep 9, 2015
Merged

[Bug 1083914] Added Datepicker to Create announcement on l10n dashboard#2643
rehandalal merged 1 commit into
mozilla:masterfrom
anushbmx:master

Conversation

@anushbmx

@anushbmx anushbmx commented Sep 7, 2015

Copy link
Copy Markdown
Contributor

This will add date picker to the create announcement pop up.

@anushbmx
anushbmx force-pushed the master branch 2 times, most recently from f090fec to 3f9d2dc Compare September 7, 2015 17:39
@rehandalal

Copy link
Copy Markdown
Contributor

test failure looks unrelated... restarting.

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

@rehandalal thanks for restarting I was wondering what made the test fail and it was unrelated. I couldn't test this on my local clone because I don know how to get that announcement button but did it a test on site with scratch pad after vesper gave me permission to do announcement in a locale.

@rehandalal

Copy link
Copy Markdown
Contributor

there are a couple of issues with this.

the code should be in wiki.dashboard.js not wiki.js.

it should be wrapped with:

if ($('body').is('.localization-dashboard')) {
...
}

also you will need to update line 5 in dashboards/localization.html to:

{% set scripts = ('wiki', 'jqueryui', 'wiki.dashboard') %}

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

Thanks @rehandalal I'll update it.

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

@rehandalal I have made the changes you mentioned, have a look.

@rehandalal

Copy link
Copy Markdown
Contributor

you are still missing the change to dashboards/localization.html that i mentioned.

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

yiks let me get that too.

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

@rehandalal Done.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the datepicker is working now but has no style. so you'll probably need to add 'jqueryui' here too.

@anushbmx

anushbmx commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

@rehandalal I confirmed its working with styles.

@rehandalal

Copy link
Copy Markdown
Contributor

looks good, thanks!

rehandalal added a commit that referenced this pull request Sep 9, 2015
[Bug 1083914] Added Datepicker to Create announcement on l10n dashboard
@rehandalal
rehandalal merged commit bcdfe18 into mozilla:master Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants