[Bug 1083914] Changed the date input made by Datepicker to YYY-MM-DD#2695
Merged
Conversation
Contributor
There was a problem hiding this comment.
i'm not sure why you deleted the addDatePicker function. you should have just modified that.
Contributor
Author
|
@rehandalal Jquery add's datepicker if the input type is set to date. So now you gonna ask why didnt this happen before, it's because we haven't included jquery before I added this. It works on my clone you can have a look. |
Contributor
|
that doesn't really answer my question about why you deleted that function. to me since you're always using the same parameters it should just go into a single reusable function |
Contributor
Author
|
@rehandalal I got it, you mean change this inside the reusable function ok. My bad i missed :D |
Contributor
Author
|
@rehandalal I have updated it now. |
Contributor
|
lgtm. thanks! |
rehandalal
added a commit
that referenced
this pull request
Nov 6, 2015
[Bug 1083914] Changed the date input made by Datepicker to YYY-MM-DD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the wrong date formate inserted by datepicker to create announcement form.