Fix revision compare RTL alignment - #7676
Conversation
| } | ||
|
|
||
| &.bottom { | ||
| background: transparent url(../img/wiki/compare.arrows.png) no-repeat p.$spacing-xs -40px; |
There was a problem hiding this comment.
It seems this was the last consumer of that png (current buttons inline its svg directly) — would it be better to also remove the asset to not keep leftovers behind?
There was a problem hiding this comment.
Yup, removing here as well.
escattone
left a comment
escattone
left a comment
There was a problem hiding this comment.
This looks great except for the alignment of the top "Compare Selected Revisions" SVG. The fix is simple though. Just remove the reverse-on-desktop class from the div on line 6 of revision_list.html, and this should be good to go.
LTR
RTL
|
Thanks for looking into this Ryan! I actually left this in the last time I was touching the line, not familiar enough with its intent to just remove it like the rest earlier. I did not like the effective layout it causes but checking its utility it seems it's neither necessary for mobile vs. desktop there, nor it affects the newly fixed charts so thanks for confirming it can be nuked — I was eyeing that in the previous PR already. 💨 Removed. |
2 participants
mozilla/sumo#3148