Skip to content

Restore award email notifications - #7710

Merged
akatsoulas merged 2 commits into
mozilla:mainfrom
denyshon:restore-award-notifications
Jul 28, 2026
Merged

Restore award email notifications#7710
akatsoulas merged 2 commits into
mozilla:mainfrom
denyshon:restore-award-notifications

Conversation

@denyshon

@denyshon denyshon commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Resolves mozilla/sumo#2347 (and resolves mozilla/sumo#2876).

@denyshon

denyshon commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Here's how the email looks currently:

Subject: You were awarded the '2026 L10n Badge' badge!
image

@denyshon
denyshon force-pushed the restore-award-notifications branch from 4bd1657 to 3f4ecbb Compare July 10, 2026 04:50
@denyshon

Copy link
Copy Markdown
Contributor Author

With my changes:
image

@kelimuttu, what do you think?

@denyshon

Copy link
Copy Markdown
Contributor Author

LTXT changes:

Before:
image

After:
image

@denyshon

denyshon commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

TODO:

  • consider switching the profile link to use the actual username, so that it works when the user is not signed in
  • add tests

@kelimuttu

Copy link
Copy Markdown
Contributor

Looks good to me. Just one small thing. Can we highlight the badge name in the LTXT version?

@kelimuttu

Copy link
Copy Markdown
Contributor

Actually, since most badges are awarded to contributors, can we add something like the following before the See all details button?

Mozilla Support is made possible by volunteers like you. Thank you for the time, knowledge, and care you've shared with the community.

@denyshon

Copy link
Copy Markdown
Contributor Author

Thanks @kelimuttu!

Regarding highlighting: AFAIK formatting is not available in LTXT, so we can only use symbols/newlines to highlight. Please let me know if you would want any of that.

Regarding the text, I love it <3 I'll see later today what is the best way to add it

@kelimuttu

Copy link
Copy Markdown
Contributor

Aah, that's ok. It's just a minor thing I don't think we need to overcomplicate. (;

@denyshon
denyshon force-pushed the restore-award-notifications branch from f029907 to e194524 Compare July 17, 2026 13:13
@denyshon

Copy link
Copy Markdown
Contributor Author

Actually, since most badges are awarded to contributors, can we add something like the following before the See all details button?

Mozilla Support is made possible by volunteers like you. Thank you for the time, knowledge, and care you've shared with the community.

@kelimuttu text added:
image

@denyshon

Copy link
Copy Markdown
Contributor Author

Also, for reference, here's a screenshot with a longer badge name:
image

@kelimuttu

Copy link
Copy Markdown
Contributor

Looks good! I wonder now if we should rename the badge to remove the badge part.

@denyshon

Copy link
Copy Markdown
Contributor Author

@kelimuttu yeah, I've been also thinking about that... But since such a change will include renaming nearly all the badges, it's up to you to decide

@kelimuttu

Copy link
Copy Markdown
Contributor

Yeah, if only there's an easy way for me to update these badges. Let's keep it the same for now and I'll take care of the renaming.

@denyshon

Copy link
Copy Markdown
Contributor Author

@kelimuttu sure. Regarding the badges, please note that annual badges should be renamed in the code (but also probably manually afterwards)

@kelimuttu

Copy link
Copy Markdown
Contributor

Oh, good point! Do you think you can file an issue to update the code? I'll take care of updating the ones we already created.

@denyshon

Copy link
Copy Markdown
Contributor Author

@kelimuttu done: mozilla/sumo#3239

Also, are we ready to mark this PR as ready for review? I've done everything I wanted from my side

@mozilla mozilla deleted a comment from ceacloud-hue Jul 23, 2026
@kelimuttu

Copy link
Copy Markdown
Contributor

Thanks, Denys. I think we're ready with this one so go ahead to request for the review from the devs.

@denyshon
denyshon marked this pull request as ready for review July 27, 2026 05:45
Comment thread kitsune/kbadge/jinja2/kbadge/email/award_notification.html Outdated
Comment thread kitsune/kbadge/badges.py
Improve award email templates
Add tests

Co-Authored-By: Kelimutu <4922388+kelimuttu@users.noreply.github.com>
@denyshon
denyshon force-pushed the restore-award-notifications branch from b7ac697 to adc0441 Compare July 28, 2026 02:41
@denyshon

Copy link
Copy Markdown
Contributor Author

@akatsoulas PR updated, could you please take another look? (and Emil seems to be fine with the tests :D)

@akatsoulas
akatsoulas merged commit ee21270 into mozilla:main Jul 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send email notifications on awards Consider sending an email notification on badge award

3 participants