Restore award email notifications - #7710
Conversation
4bd1657 to
3f4ecbb
Compare
|
@kelimuttu, what do you think? |
|
TODO:
|
|
Looks good to me. Just one small thing. Can we highlight the badge name in the LTXT version? |
|
Actually, since most badges are awarded to contributors, can we add something like the following before the
|
|
Thanks @kelimuttu! Regarding highlighting: AFAIK formatting is not available in LTXT, so we can only use symbols/newlines to highlight. Please let me know if you would want any of that. Regarding the text, I love it <3 I'll see later today what is the best way to add it |
|
Aah, that's ok. It's just a minor thing I don't think we need to overcomplicate. (; |
f029907 to
e194524
Compare
@kelimuttu text added: |
|
Looks good! I wonder now if we should rename the badge to remove the |
|
@kelimuttu yeah, I've been also thinking about that... But since such a change will include renaming nearly all the badges, it's up to you to decide |
|
Yeah, if only there's an easy way for me to update these badges. Let's keep it the same for now and I'll take care of the renaming. |
|
@kelimuttu sure. Regarding the badges, please note that annual badges should be renamed in the code (but also probably manually afterwards) |
|
Oh, good point! Do you think you can file an issue to update the code? I'll take care of updating the ones we already created. |
e194524 to
b7ac697
Compare
|
@kelimuttu done: mozilla/sumo#3239 Also, are we ready to mark this PR as ready for review? I've done everything I wanted from my side |
|
Thanks, Denys. I think we're ready with this one so go ahead to request for the review from the devs. |
Improve award email templates Add tests Co-Authored-By: Kelimutu <4922388+kelimuttu@users.noreply.github.com>
b7ac697 to
adc0441
Compare
|
@akatsoulas PR updated, could you please take another look? (and Emil seems to be fine with the tests :D) |






Resolves mozilla/sumo#2347 (and resolves mozilla/sumo#2876).