Skip to content
This repository was archived by the owner on Sep 22, 2020. It is now read-only.

cross-wm-tool cookie management#47

Merged
Pomax merged 8 commits into
mozilla:masterfrom
Pomax:bug867218
May 7, 2013
Merged

cross-wm-tool cookie management#47
Pomax merged 8 commits into
mozilla:masterfrom
Pomax:bug867218

Conversation

@Pomax
Copy link
Copy Markdown
Contributor

@Pomax Pomax commented May 6, 2013

surgically injected all the working bits on top of master.

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the secure cookie action going on here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll find out whether expressjs/express#1607 can tell us what wisdom is, here.

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a link to localhose here so people can go read more details.

Comment thread README.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File a follow-up bug to fix this, deployment on Heroku shouldn't require renaming an environment variable

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pomax added a commit that referenced this pull request May 7, 2013
cross-wm-tool cookie management
@Pomax Pomax merged commit a50d164 into mozilla:master May 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants