Fix some warnings and make them appear in Bazel#2434
Merged
Conversation
Make Errorprone checks more consistent between Gradle and Bazel builds Clean up some errors in code and in Javadoc that we let creep in recently that Errorprone has been trying to tell us about.
rbri
approved these changes
Jun 18, 2026
rbri
left a comment
rbri
left a comment
Collaborator
There was a problem hiding this comment.
looks like some unused code is gone - i like
maybe you can have a look at this two jdoc warnings also...
Collaborator
Thanks |
Contributor
|
This looks good. I had something similar lined up in my queue but hadn't got to it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Errorprone checks more consistent between Gradle and Bazel builds
Clean up some errors in code and in Javadoc that we let creep in recently that
Errorprone has been trying to tell us about.
Making them more likely to show up in Bazel also makes it more likely that I
will notice them during code review!