Handle strict mode better in direct eval.#2447
Merged
Merged
Conversation
Collaborator
|
@aardvark179 spotlessApply |
rbri
approved these changes
Jul 16, 2026
aardvark179
force-pushed
the
aardvark179-strict-eval
branch
from
July 16, 2026 11:33
b3138cc to
c6277e1
Compare
aardvark179
force-pushed
the
aardvark179-strict-eval
branch
from
July 16, 2026 16:52
c6277e1 to
d09cd01
Compare
Collaborator
|
smoke tested with HtmlUnit - fine ❤️ |
Collaborator
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to reduce the differences between our fork and here to make merging down easier. This one came up because it was originally implemented as a special case in the interpreter, but seemed better suited to being in
evalSpecialitself.